Hi, it seems that there is a conflict for version of chardet package used - requirements.txt has binaryornot < 0.4.3, which in turn requires chardet < 3.0.0. The current version of requests requires chardet > 3.0.2. When running e.g. setup.py install, this makes the operation fail on a dependency problem, e.g. error: chardet 3.0.4 is installed but chardet<3.0.0 is required by set(['binaryornot']).
chardet
requirements.txt
binaryornot < 0.4.3
chardet < 3.0.0
requests
chardet > 3.0.2
setup.py install
error: chardet 3.0.4 is installed but chardet<3.0.0 is required by set(['binaryornot'])
I found out that the version of requests that can use older chardet is 2.15.1 (so you can pip install requests==2.15.1 chardet<3 before setup.py install), but perhaps it'd be better to switch to newer version of binaryornot, which can work with chardet>=3.0.2.
2.15.1
pip install requests==2.15.1 chardet<3
binaryornot
chardet>=3.0.2
Looks like it was added in https://pagure.io/pagure/c/89c9932de475c33aa2e60b13b110c26760fe6fea :)
Then we added support for newer chardet in https://pagure.io/pagure/c/8ac14cf0076396c0809034f0f8f0d0c731fdad39
So I guess it should be fine to remove that constraint.
Metadata Update from @pingou: - Issue assigned to pingou
The current requirements.txt on master branch still has binaryornot < 0.4.3 and just chardet and requests, so the problem still exists there, AFAICS.
Commit f7eb75cf fixes this issue