Checking which branches can be turned into pull-request has now been moved to be processed by the workers on the backend, so depending on the load on the server it can be faster or slower.
This was done as the alternative was increasing sensibly the load on the server or timing out depending on the implementation (and number of branches to check).

Could you link me to the project that was being very slow for you? I'd like to make sure it was just slow and not that you ran into a bug :)

It was on this project- Pagure :)

I would suggest if after a certain amount of time it times out and returns a alternative method, such as submitting the PR from your fork. This had me pulling my hair out last night trying to submit a PR! :joy: A simple message like "Too many options! Please submit the PR from a fork" would have saved me much headache.

Alternatively, it doesn't really seem necessary to load all of these options in the button anyways. Is there any reason this can't move to a new page where the user can individually select the project branches to request the PR on (similar to GitHub)? What's the benefit of doing it this way if it is likely to break UI?

I've been using this drop-down a few times today, so I'm really pretty sure it works fine :)

Note that you can also open a PR from the page listing the branches: https://pagure.io/fork/marykatefain/pagure/branches

That is so strange... I just tried it again on different wifi so I am sure it's not just my home wifi.... :confused:

I did eventually figure out how to do it without the button, it just took a while, haha. I just hope others aren't deterred from contributing because it seems that "Open PR" is not available. But maybe it's just me for some reason! :) Is anyone else able to replicate it?

I think https://pagure.io/pagure/pull-request/3819 may have fixed this as well

Alright, pagure 5.1.1 is out and deployed.

Does the new look of that drop-down menu makes it better for you?

Oh yes this is so much better! The branches still won't load, but at least now there is feedback on the button so it is clear what's happening! thank you :)

Doesn't load at all or takes a while to do it?

I clicked the button at 11:47 and let it run for a while just to be sure... 10 mins later still loading. So maybe it just "takes a while" but I have yet to see the end. I'll keep it open for a while longer and report back if it ever shows!

FYI nearly 2 hours later it's still spinning.

Do you know how to use your web-browser's web console? Could you open it before clicking on it and see if you have any errors either in the javascript console or in the network calls it makes?

On page load here's this error in the console about a font:

Refused to load the font '<URL>' because it violates the following Content Security Policy directive: "default-src 'self' https:". Note that 'font-src' was not explicitly set, so 'default-src' is used as a fallback.

As well as a bunch of unreturned data:font/woff;base ... calls in the network tab.... But nothing additional seems to happen in Network or Console when I click the "Open PR" button.

Did you reload the page before clicking on the drop-down?

I've just tried it here, there are two POST requests to a "ready" endpoint. Do you not see these?

I tried it both ways to be sure. Here is what I see if I click the button after loading the page:

This is really odd, do you have some sort of privacy plugin in your profile by any chance?

The same happens to me too. Spinning infinitely. No errors reported neither in Console nor in Network.

Just ad block, and disabling it doesn't seem to fix it. I also tried in an Incognito window and Firefox, and I could not get anything to load in either of those either.

@lenkaseg - Glad I'm not the only one! I was feeling crazy hahah

And on a local pagure instance, can you reproduce this?

Now that 5.2 has been released and deployed, is this issue still happening?

To me yes.

@lenkaseg could you try reproducing it at https://stg.pagure.io and give me the steps you followed to reproduce it?

well...I just click onOpen PR button and it loads indefinitely (to be correct I waited 5 minuts). Both here and on https://stg.pagure.io. On local instance of Pagure, it loads in 3 secs.