pagure

#5018 List-ID headers not syntactically valid
Opened by tibbs. Modified

Open
Close Issue

I just happened to notice that Pagure adds a List-ID header to notifications, which is useful. But sadly they are not syntactically valid according to RFC2919. Pagure List-IDs look like this:

List-ID: releng/fedora-scm-requests

But the actual format looks more like an email address (and the angle brackets are mandatory):

List-Id: List Header Mailing List <list-header.nisto.com>
List-Id: <commonspace-users.list-id.within.com>
List-Id: "Lena's Personal Joke List"
         <lenas-jokes.da39efc25c530ad145d41b86f7420c3b.021999.localhost>
List-Id: "An internal CMU List" <0Jks9449.list-id.cmu.edu>
List-Id: <da39efc25c530ad145d41b86f7420c3b.052000.localhost>

I checked and dot-atom-text (defined in RFC2822) does permit the / character so just appending a dot and the domain name (or .localhost) and surrounding the thing in brackets would work to make the headers valid.

As for whether this would break existing filters, it wouldn't if those filters just look for List-ID headers containing the current strings. If they did an exact match, though, obviously that would break.

Do you recommend we fix this (and break potential filters) or leave it as is (and be bad citizen :( )?

One option may be to fix this in 6.0
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.