Need to write unittest for this pr
rebased
we are good for a review. Let me know of any issues
issue #1003
Looks good, could you rebase it? I try to keep the history linear :)
will do tomorrow morning :) i haven't had experience using rebase could you verify if this command is correct
git rebase <my_fork> upstream
@skrzepto git fetch upstream and then git rebase upstream/master
git fetch upstream
git rebase upstream/master
pingou needs to cut a release.
Pull-Request has been merged by pingou