why the change?

:thumbsdown: for renaming the variable

same as above

and here as well

I'm not sure I understand the changes made here

what's happening when you not logged in?

This is specific to user when they are not logged in lines following check if the user is authenticated! hence private will be false everytime

This function is called only when user is authenticated

To make the code consistent throughout the file!

will undo it ! was trying to keep the code consistent!

But you didn't fix the rest of the method so you actually broke it :)

Wasn't it simpler to fix the one using if repo is None instead? Seeing how many if not repo you changed :)

Then shouldn't private in search_projects be False by default which would save us from specifying it here where it's not needed?

I guess that if we change the private to default to False, we'll need to adjust things here

I figured that after you pointed that :tongue: my bad!

There are a few files where you should add your name in the headers :)

Will this https://pagure.io/fork/farhaan/pagure/blob/private-repo/f/pagure/ui/app.py#_33 show private projects? (Logged in? Logged out?)

Will this https://pagure.io/fork/farhaan/pagure/blob/private-repo/f/pagure/ui/app.py#_33 show private projects? (Logged in? Logged out?)

Nevermind, with private=False as default it won't indeed :)

Ok, fix the header and I'll merge :)

which all files ? :smile:

which all files ? 😄

The ones you changed of course :)

Alright, let's merge this one :)