#1081 Add the initial gpg signature check code
Merged by pingou. Opened by puiterwijk.
puiterwijk/pagure signaturecheck  into  gpg_check

Download 1081.patch

This does implement verification of signatures on commits and tags.
It does not implement getting the keys from a keyserver, verifying
the key is owned by the user, or any UI to indicate signature state.

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

rebased

There are quite a few 'print' remaining :)

rebased

Removed, sorry for that.

Why the delete=False?

Because I had left that over from debugging :)

rebased

rebased

rebased

This looks fine to me with two small remarks:

  • unit-tests?
  • it's incomplete to be fully functional (while it won't break anything it will also not provide any info)

As such, I am leaning on either leaving it as a PR or merging it to a dedicated branch that we'll merge into master when things are fully working

rebased

I think we should remove this one and let bleach pull the version it needs.

IIRC fedora-hubs had some problem with this one :(

rebased

rebased

Merging this to its own dedicated branch until we can finish the code :)

Pull-Request has been merged by pingou

Metadata