#1135 Implement scanning of attached files for viruses
Merged by pingou. Opened by puiterwijk.
puiterwijk/pagure virusscan  into  master

Download 1135.patch

It's really quite ugly that one test case impacts all the others...

Make sure that you have a clamd running on a local, unix, socket.

No message?

Seems not. I am passing the validationerror just like wtforms would, so I guess you're not sending the message on.

I'm curious why the sha of the file changed, should we do something like seek(0) or so?

Should we adjust the doc to include these instructions?

Which raises the question: should we have a configuration key to turn on/off this feature?

rebased

rebased

Config key and docs added.

I try to keep the 80 chars rule also in the doc, could you see to split a few of these lines to follow it as well?

VIRUS_SCAN_ATTACHMENTS should also be documented in the configuration.rst file, just specifying what it does, what is the default and referring to this document for setting things up.

Hm, any idea why the sha of the file changed here?

rebased

rebased

Should we move this in file_virus_validator to make scanning virus entirely optional (including from a deps point of view)?

If we do that, we should also mark the pyclamd as optional in the requirements.txt.

What do you think?

rebased

rebased

rebased

rebased

Looks all good, thanks! :)

Pull-Request has been merged by pingou

Metadata