<a href="{{ url_for('new_issue',username=username, repo=repo.name) }}" there should be a space before username to go with the convention. Other than that looks good to me :thumbsup: ! Can you please do the following changes. :smile:

I should make changes and again do add commit push and PR in same branch right.

@anjali only commit and pushing to the same branch should do the job :)

seems good to me let @pingou and @vivekanand1101 see it and then you can squash commits and we can merge it . :)

i like the idea here, and thanks for the patch!

although, i think that filing a new issue could even be a top-level action, so users can file a new issue anywhere in a repo.

the best location for it would be in the buttongroup at the top right of the repo_header (where the watch button and the fork button are). Be sure to rebase from master though, as i recently cleaned this area up so it should be easier to add a button there now.

Welcome and putting new issue button at top-level action is really nice idea.

should i remove "New Issue" button on issues page else there will be two buttons for adding new issue on one page.

should i remove "New Issue" button on issues page else there will be two buttons for adding new issue on one page.

Sounds good to me :)

Let us know when you have adjusted this PR (and if you could rebase as well) :)

I have
two remotes origin(forked repository) and upstream (pagure repository)
two branches in origin master and issue/1127

To get new code i did "git pull upstream master" in branch issue/1127 i got a merge commit but i think according to rebase my commits in git log should be at top so i again reverted the merge commit and even that got added to git log. I think i messed up sorry please help.

@anjali can you show your git log ? you can use: https://paste.fedoraproject.org/

"git pull upstream master"

You were almost there, you just missed the --rebase argument.

the command should have been: git pull --rebase upstream master

"git pull upstream master"

You were almost there, you just missed the --rebase argument.

the command should have been: git pull --rebase upstream master

git log https://paste.fedoraproject.org/396327/24783146/

git log https://da.gd/NA6VC sorry for above link

Is the position of "New issue" button ok http://img.susepaste.org/89936438

Is the position of "New issue" button ok http://img.susepaste.org/89936438

@anjali can't guarantee that others will like but it looks good to me

:thumbsup: from me for the location of the button!

@anjali if you could rebase once more, I'll merge :)

(git pull --rebase upstream master if I remember correctly)

@pingou according to ryanlerch's comment, i think he wants to place the button in all the pages for the repo (repo_master probably) and not just the issue page.

1) http://img.susepaste.org/97725911
2) http://img.susepaste.org/89936438

Above are the two ways we can put New Issue button which one i looking good and @pingou i have done rebase yesterday now i should just commit the changes right?

I like the one with the space between and @anjali you need to push it with a -f option since you have rebased it it changes the history.

@anjali as long as the scare at the top right (above Assignee is not green), you need to rebase :)

http://img.susepaste.org/19403077

my last two commits are of no use(from first PR) due to decision of putting New Issue button at top level.So should i do something of it.I haven't done any PR yet after rebase.

You could have just sent a link what you can do is squash your commits.

http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

Looking good, thanks!

Thakyou @pingou @farhaan @vivekanand1101