There is a GET for this endpoint?

I checked I only need POST for both the urls

Indentation is off

Did you check https://pagure.io/fork/farhaan/pagure/blob/fork-edit/f/pagure/templates/file.html#_94 ?

Checking the file type ?

This needs unit-tests :)

Why POST requests?

The URL supports POST and with GET I get a 404 which is not the supposed output.

Looks good, the only missing part is: checking if/when the button is showing up :)

@pingou in tests ?

@farhaan yes that would be easier to check :)

Why are you adding binary data since you're not using it anywhere?

Give some space in between your checks

Sorry you are with test.jpg, but not this one indeed :)

Doesn't show?

Even more: doesn't show on binary file

2 lines at the end

Could we explain why 404?

Could we explain why 400?

This checks if the user is not logged in

Ok so remaining comments:

• Explain the 400 error (cf other examples in the code)
• Explain the 404 error
• Add test checking if the Fork & Edit button is showing when the user is not logged in

Looks good to me, thanks! :)

Finally thank you :)