pagure

#1169 Add conf key for private projects
Merged by pingou. Opened by farhaan.
farhaan/pagure private-repo  into  private_repo

Download 1169.patch
no initial comment

LGTM :thumbsup:

Do we need to change anything in the searches?

If not, looks good to me :)

No ! it's already done https://pagure.io/pagure/blob/private_repo/f/pagure/ui/app.py#_248

hence it will not list out private project to non authorized user.

1 new commit added

  • Fix test after the addition of conf key

What happens when if someone turns off the key after running for few days? Do we need to show the private projects then? According to current code it will. (to the authorized ones)

@vivekanand1101 I think this is acceptable. Otherwise the private project would end up completely hidden which I don't think would be a good thing.

Alright, let's merge :)

@vivekanand1101 I think this is acceptable. Otherwise the private project would end up completely hidden which I don't think would be a good thing.

Alright, let's merge :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.