pagure

#1200 Pep8 issues fixes
Closed by williamjmorenor. Opened by williamjmorenor.
williamjmorenor/pagure pep8  into  master

Download 1200.patch

First than all, the tool was remaned to pycodestyle, any way some pep8 codestyle fixes

2 new commits added

  • Fix E302 expected 2 blank lines pep8 issues
  • Fix E303 too many blank lines pep8 issues
williamjmorenor commented

https://paste.fedoraproject.org/405825/70866929/

It is posible to add a automatic pycodestyle in test:

https://pycodestyle.readthedocs.io/en/latest/advanced.html

But it will breake the build for a long time until all issues are fixed or ignored, but after that the autotest will prevent to introduce new pep8 issues, sound good that?

1 new commit added

  • Create the checkstyle.sh file

This is required for pagure-ci?

I'm fine with the new lines/dropped lines changes but I'm not sure about the checkstyle.sh script and there is a reason for the content of requirements.txt to be this way :)

Why not put the list of ignores into setup.cfg or tox.ini file? That way it would be useful for people that integrate the check into their editor (without having to bend the editor to run this script).
williamjmorenor commented

At this time there are many issues, the idea es to prevent to new issues comming into pagure but do not make a lot of noises with current issues.

I can revert the commit adding the script, it is just pycodestyle with a list of ignored issues.

43 new commits added

  • Remove not necesary backslash between brackets
  • Fix some missing whitespace
  • Fix E231 pep8 issues
  • show groups when user mngt is turned off
  • alembic: display name and description columns in pagure_group
  • Small grammar fix, thanks @puiterwijk
  • Specify the max length of the field so the input gets validated early
  • Small style change in the model
  • Adjust the unit-tests for the change in behavior
  • Show the display name when listing the groups, put the group name as title
  • Fix the title of the page and add a button to edit the group's info
  • Pre-fill the content of the form if the request was a GET
  • Make the edit_group template pretty!
  • Only notify if there is a project to be notified about
  • Drop the small red stars, they aren't used anywhere anymore
  • Add unit-tests around the edit_group feature
  • Adjust the unit-tests for the change in the group model
  • Add the possibility to edit group info
  • Specify display name and description when creating a group
  • Add a to_json() method to the PagureGroup objects
  • Add a display_name and a description to groups
  • Fix unit-tests
  • Adjust syntax for a note
  • Add a documentation on how to install pagure-ci
  • Document PAGURE_CI_SERVICES in the documentation
  • Adjust the title levels in the pagure_ci_jenkins doc
  • Fix including the pagure_ci_jenkins page
  • Do not repeat information from the doc, rather point to it
  • Include pagure_ci in the usage doc
  • Introduce the pagure_ci_jenkins doc, specific for jenkings/pagure integration
  • Make the pagure_ci home page something generic
  • Move the pagure_ci doc into the usage section
  • Looks like arrow changed a little bit its API/wording
  • Let's just not change VIRUS_SCAN_ATTACHMENTS in jenkins
  • Add a docstring to reload_pagure
  • Turn off testing pyclamd on jenkins
  • Drop reloading pagure.api.ci.jenkins
  • Disable the virus scanner for testing pagure/ui/repo.py
  • Do not run this section of the tests if there are no PAGURE_CI_SERVICES configured
  • Move all the logic to reload pagure off flask_ui_old_commit
  • Document multiple key per user feature
  • Add a ssh key screenshot
  • Revert "Create the checkstyle.sh file"

This is odd, it looks like you rebased but the commits have a different hash and thus they appear different.
williamjmorenor commented

This is odd, it looks like you rebased but the commits have a different hash and thus they appear different.

Will try a git squash to fix it :cold_sweat:

rebased

I have a large, project-wide pep8/pylint fixes branch (cf pep8_fixes) that will be coming up for review in a few. I believe it will include the fixes you made here, so do you mind if I close this PR for now?
williamjmorenor commented

Sound good

Pull-Request has been closed by williamjmorenor
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.