I think there is a pep8 problem here 80 chars limit

I think you should add the docstring here explaining search_pattern parameter

i think there is a indentation issue.

we can put this line just below "author" one. (we are getting other request variables there only)

@anjali you should attach a screenshot. We will need @ryanlerch 's opinion for UI.

What if the pattern contains a * or what if the user wants to do a exact match search?

@anjali you should attach a screenshot. We will need @ryanlerch 's opinion for UI.

Image http://img.susepaste.org/13643694

@pingou search implemented is not searching a regex may be variable name is misleading and for exact match space before and after search word works otherwise it wont.

I wonder if cryptography isn't going to end-up a dependency of core which will solve this question :)

(cf #1105)

A few comments from a UI perspective (just from the screenshot). Are you able to also post some screenshots of how it works when you actually search? is there another page that shows up, or does it just filter the list down with JS?

1. The positioning looks good in the screenshot. However, i wonder how this will work on smaller screens when there are multiple tags showing up in the issues. These currently don't wrap super neatly as it is, but you should test by adding a fair number of tags to the project to see how it behaves.

2. As for the search box itself, to keep with the same visual style as all the other form elements in pagure, you will need to use bootstrap forms. Button addons in input groups is probably the way to go with this element: http://v4-alpha.getbootstrap.com/components/input-group/#button-addons

@ryanlerch I am not good in css. Do I have to create a new class like shown in above given link for search bar and button.

The class should already exists, you just need to use them :)

@ryanlerch
http://img.susepaste.org/39819594
I made
col-md-3(open/closed button/tag symbol),
col-md-6(multiple tags),
col-md-3(Search bar)
but space between open/closed button/tag symbol and tags is too much how can I reduce it and i tried changing grid column size but still space is too much .Is this the right way to do

Okies! This search / tagging area really does need an overhaul. So for this PR, i reckon just style up the search box as per your screenshot above.

This way, we can merge the search functionality, then i can work on some mockups later to overhaul this whole area.

@pingou what do you think?

@pingou what do you think?

Sounds good to me :)

Looks like we can no longer merge this PR, could you rebase it? :)

Hi there,

Is there anything I can help with so that we can this merged?

@pingou , http://img.susepaste.org/3203936 I want to increase the height of tags section which attribute should i change and want to remove right-side border of search button which can be done by removing padding-right attribute of col-lg-3 but it will take effect for all col-lg-3 used in project which should not happen.

@anjali maybe you could start by pushing what you have now so that more people can see it and eventually play with it?

Ok, with the following patch, this feature works for me:

Here is a screenshot:

If you could apply this patch and rebase, then I'll merge :)

This works for me!

Hm, why is there only 2 commits from you? Where is mine? (my two commits I should even say)

Ok, I was able to find back the original commits of this PR.

I took the opportunity to rebase it.

Since I contributed to it, does someone want to review it?

Thanks! :)

I see no reason for rebuilding the entire query from scratch.
Just query = query.filter(model.Issue.title.like(......) will do the trick.

Good catch!

:thumbsup_tone4:

Thanks for the review!