Fixes Issue no - #1225 Before clicking to view fork : http://img.susepaste.org/51603371 After clicking to view fork : http://img.susepaste.org/11782857
1 new commit added
:thumbsdown: for this change, it's specific to how you configured your dev instance
Can this be a link instead of a button?
It would allow not relying on JS below since we're within the correct form.
Or maybe the button below could just be an input button and this one not. Something to test.
I'm not sure this conditional is fixing #1225, I'm even pretty sure it's not :)
2 new commits added
:thumbsup:
:thumbsup: from a design point of view
Is this line actually needed?
This conditional isn't what we need, this just check if the repo has forks, not if you have one
@pingou I got you. I am working in it. Was busy in my office work from last few days. Will send you the modified PR asap.
Cool @tenstormavi
I was just replying so let folks know that my initial remarks are still valid :)
Anything I can help with here?
@pingou yes. I was trying but didn't succeed. In the fork.py file I changed https://paste.fedoraproject.org/431246/ into https://paste.fedoraproject.org/431257/
And in the repo_master.html I did this https://paste.fedoraproject.org/431248/43499801/
Can you suggest me something on this, where I am doing wrong?
Well, the first thing is that you need to have this info available on every page of the project, so changing fork.py is really not enough (and tbh, not the right place either since we merged #1274).
The change to repo_master.html will likely need a little adjustment but the basic idea is there.
ping?
pong. @pingou I am really busy right now with my office work so didn't get time to look on the bug again. Can you at least help me with exactly in which file I have to make the changes other than repo_master.html? Just the file name and I will do the implementation part.
Check the pull-request I pointed to above :)
I've taken over this PR in #1456 so that it works on all pages of the project.
Thanks for starting this @tenstormavi and sorry for taking over but I'd like your work to be in the next release :)
Pull-Request has been closed by pingou
Fixes Issue no - #1225
Before clicking to view fork : http://img.susepaste.org/51603371
After clicking to view fork : http://img.susepaste.org/11782857