#1287 Fixing typos in the documentation files.
Merged by pingou. Opened by sergiodj.
sergiodj/pagure fix-typos-doc  into  master

Download 1287.patch

A few typos caught by Debian lint.

@sergiodj -

if you are interested i corrected quite a bit of the docs myself here https://github.com/bill-auger/pagure/pull/1 if you want to pull in my changes plz do

i have not showed these to anyone yet mostly because there are more points that need attention that i would need to ask for clarification about first

Looks good to me.

@sergiodj do you want me to merge or are you interested in pulling in @billauger 's changes now?

On Friday, September 09 2016, pagure@pagure.io wrote:

pingou commented on the pull-request: Fixing typos in the documentation files. that you are following:
``
Looks good to me.

@sergiodj do you want me to merge or are you interested in pulling in @billauger 's changes now?

Hm, I'd prefer if you pulled my changes right now. I don't have much
time right now to work on that, and besides @billauger 's changes
contain a typo ("grammer"), so I'd have to review them :-).

Thanks,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

boy is my face red :)

@sergiodj - you do not actually need to review them - that is the job of the repo maintainer or peer-review process - i was suggesting literally to cherry-pick my commits as-is on top of yours and let others review the correctness

but indeed there is a typo in the commit message - in my defense i did not intend for those to be merged - i will rebase after this PR is merged then correct it

On Friday, September 09 2016, pagure@pagure.io wrote:

@sergiodj - you do not actually need to review them - that is the job
of the repo maintainer or peer-review process - i was suggesting
literally to cherry-pick my commits as-is on top of yours and let
others review the correctness

I understood your suggestion, but I don't quite like the idea of leaving
the work to others when I know the PR has problems. Also, your fixes
were not caught by lintian so I find it clearer to file a new PR for
them.

but indeed there is a typo in the commit message - in my defense i did
not intend for those to be merged - i will rebase after this PR is
merged then correct it

Sure, no problem.

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Alright, so let's merge this one and we can merge the other one later.

Thanks for everything folks :)

Pull-Request has been merged by pingou

Metadata