I doubt that this css file will works since it relies on these files that aren't present.

I wonder if we shouldn't just use a regular font instead of making the user download one

related issue --> https://pagure.io/pagure/issue/1259

Easiest fix would be to just update this to https://fonts....

yes puiterwijk's suggestion is simpler but i think the intention of this PR is to host the fonts on the same server as pagure which is a superior fix

pingou has raised the point that perhaps the user should not be required to download any fonts at all which is the simplest solution of all and ideal so far as the designers do not object

the best general rule is to avoid and remove external dependencies if at all possible (occam's razor principle) - but another issue which is one of notabug's core principles is to ensure visitors to the site are served all assets from the same domain and never contact any external server

so @designers? where are these fonts actually used? is anyone going to notice the difference if they change? - these fonts are currently falling back on the browser default font now - yes? and is anyone complaining about this or asking for prettier fonts?

@pingou , how shall i go ahead with this bug ?

-should i just add the files that are required for fonts.css to run?

-or should i go with @puiterwijks suggestion?

@ryanlerch your help is needed here :smile:

@rahulbajaj did you test your change?

From local testing, it doesn't seem to remove the URL to google.

I've tried with a little more success with:

--- a/ doc/conf.py      
+++ b/ doc/conf.py      
@@ -155,6 +155,8 @@ html_theme_options = {
     "codetrimcolor": "#79db32",  # First Green
     "footerbgcolor": "#FEFEFE",
+
+    "fontcssurl": "",

I am not sure what happened here but the resulting change doesn't seem to be what you were trying to do :)

Sorry that I couldn't catch you on IRC today, but looking at this PR, you may want to start your change all over, from a clean clone even as it looks like here that several commits (not all from you) have been squashed together.