I don't understand how this code is different from the previous one (about use of raw_data). From this, in case someone comments on the issue: raw_data gives an empty unicode string inside [], which evaluates to True for if condition while data gives the just the unicode string which evaluates to False. In the previous implementation, we used data so, it would evaluate to False and thus new_milestone would be set to None. Check this one. The same thing happens in the new implementation, since, raw_data will be evaluated to True and then same step happens.

Well, the use of raw_data allows getting ride of this https://pagure.io/pagure/pull-request/1368#_1,6 which I think is a good thing.

@pingou , but, if someone enters 'None' in the namespace, raw_data within if will pass and namespace will be set to string None. Where am i wrong in this?

The behavior I was seeing was when no namespace was specified, it would return me a 'None', if the namespace 'None' is specified, then there is nothing we can do indeed :)

This is surprising but, how did it get fixed? because, if it still giving 'None', then it will be stored as 'None'.

ok, I'm going to drop part of this change, I can't reproduce the issue I had anymore :(

:thumbsup:

Thanks for the review :)