PR#1376: Fix displaying why a PR cannot be merged - - Pagure.io

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

pagure

#1376 Fix displaying why a PR cannot be merged

Merged Oct 4, 2016 by pingou. Opened Oct 3, 2016 by pingou.

fix_pr_merge_status into master

Download 1376.patch

pingou commented Oct 3, 2016

Fixes https://pagure.io/pagure/issue/1366

farhaan commented Oct 3, 2016

Trying it out :smile:

puiterwijk commented Oct 4, 2016

It looks sane enough to me.
But it looks like this isn't tested?

pingou commented Oct 4, 2016

Test the javascript in unit-tests?

We don't have tests using selenium or such

puiterwijk commented Oct 4, 2016

Test the result of the endpoint :).

pingou commented Oct 4, 2016

I think the result is tested, but here the result of the API was correct, its processing wasn't :)

puiterwijk commented Oct 4, 2016

Ahhh, okay. Fair enough then.
:thumbsup_tone2:

pingou commented Oct 4, 2016

Thanks :)

rebased

Oct 4, 2016

Pull-Request has been merged by pingou

Oct 4, 2016

Metadata

Assignee

None

Tags

No Tags

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.