pagure

#1391 Default hook
Merged by pingou. Opened by pingou.
default_hook  into  master

Download 1391.patch

This PR adds a default hook, installed into all the new projects which cleans the merge
status of all open PRs of a project upon pushes.

Fixes #1359

We can start the review of this PR but I'll add unit-tests for its install/remove.

3 new commits added

  • Add unit-tests for the default hook/plugin
  • Do not allow changing the default plugin via the UI
  • Style fix (tab -> spaces)

1 new commit added

  • Some more style fixes (tab -> spaces and indentation)

Forgot to edit this one

This can be a required field, no ? I know it doesn't affect much. just a thought.

why this ?

This will be pagure's 3rd Mail hook . :tongue:

A few stupid comments. Else: :thumbsup:

Edited by vivekanand1101

Boolean fields cannot be required as they only have two states: present/absent, So if you ask them to be Required, it means they will always be present (and thus True).

copy/paste for the win :-p

Because since we fixed the field with the coerce, it can return None and None object cannot be strip()

1 new commit added

  • Fix docstrings in the default hook

:thumbsup:

thanks for the review :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.