Turns out jenkins wasn't using faitout so some tests were passing when they shouldn't have. This PR brings back the expected and desired behavior.
rebased
?
it's re-set just under
Let me remove that one
1 new commit added
Out of curiosity, is there a reason for not using the Python recommendation of logging.getLogger(__name__) (https://docs.python.org/2/library/logging.html#logger-objects)?. I've noticed a lot of places in Fedora infrastructure projects that don't do that and I've not encountered it before.
logging.getLogger(__name__)
I like to be explicit about the name of the logger but beside that there isn't really a clear reason for me
so, currently we are not searching on the basis of close_status ?
close_status
I need to visit an ophthalmologist
:thumbsup:
Thanks for the review :)
Pull-Request has been merged by pingou
Ah okay. One thing I really like about the logging.getLogger(__name__) convention is that it is immediately obvious what Python module emitted the log entry, not just the package responsible. Without it, the only way I know to track down the module is to start grepping and hope I pick the right bit of the log message that isn't a variable, and that there is only one module with that log message.
It's not really a huge deal, of course, but it saves a bit of time when debugging.
Turns out jenkins wasn't using faitout so some tests were passing when they
shouldn't have.
This PR brings back the expected and desired behavior.