pagure

#1437 Add a link to the user on the commit list
Merged by pingou. Opened by ryanlerch.
ryanlerch/pagure commitlist-user-link  into  master

Download 1437.patch

This adds a link to the user on the commit list.
It required a little more playing than just adding
the link, as the previous iteration had a single tag
that just wrapped everything. So we had to pull this out,
and add a link to the user on the username text.

Fixes: #1413

we can do better than this, let me push a commit to your fork

The links are showing in blue instead of the dark grey we had, is this intended?

1 new commit added

  • Simplify a little how the css class is added to the user link on the commit list

2 new commits added

  • Simplify a little how the css class is added to the user link on the commit list
  • Add a link to the user on the commit list

Yes, this is intended.

Previously, we only had one link in the list, so the entire list item was a link -- so they were not blue. Now that we have multiple links, it makes more sense that the primary link is blue.

2 new commits added

  • Create a Vagrantfile and Ansible role for Pagure development
  • When searching groups, search both their name and display name

2 new commits added

  • Simplify a little how the css class is added to the user link on the commit list
  • Add a link to the user on the commit list

rebased

OKies, we should hold off on this one until we merge #1438 . That way, we can add a link to the user profile page on the avatar, and a link to the filtered list of their commits on their name.

Yes, this is intended.
Previously, we only had one link in the list, so the entire list item was a link -- so they were not blue. Now that we have multiple links, it makes more sense that the primary link is blue.

Changed my mind on this one again. Going back to the non-blue link.

1 new commit added

  • remove the blue links on the commit page

Changed my mind on this one again. Going back to the non-blue link.

Cool, I liked them better not blue :-p

rebased

1 new commit added

  • Create a dedicated jinja filter for showing the author in the commit list

@ryanlerch what do you think of these last changes?

rebased

LGTM! :thumbsup:

Thanks, let's merge :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.