#1450 correlate or remove orphaned config keys
Merged by pingou. Opened by billauger.
billauger/pagure docs-patch  into  master

Download 1450.patch

i have compiled a list of configuration keys that are not correlated between the documentation and the default config file - these should probably be sorted out to be made consistent

some of these (namely FORK_FOLDER) i have been told are obsolete and should be removed but there are several others i am not sure about

FORK_FOLDER was removed from the documentation in PR #1447 but i just noticed that it is still present in (the default config file on the master branch)[https://pagure.io/pagure/blob/master/f/pagure/default_config.py#_96]

ive opened this issue as a PR to make it easy to comment on each item line-by-line - once all keys are marked as be either (REQUIRED) or (OBSOLETE) i can make the appropriate changes then rebase this as a merge-able patch

Used: the different ACLs an API token can have

Used: the lifetime of the session during which the user won't have to re-login for admin actions

Used: list of hard-coded/allowed namespaces

Used: used for the cookie path

Used: list of group whose names are blacklisted

Both used: allows to host the bootstrap files yourself w/o relying on fedoraproject.org

Used: turn on/off managing group in this pagure instance

Used: turn on/off managing users in this pagure instance

I'm still seeing one instance of it, but it should be cleared

Used: name of the cookie

Used: allows specifying what is shown on the index page

Used: allows specifying what is shown on the index page

Used: Defaults to False

Used: defaults to False

Used: No defaults

Used: Defaults to None

this is one of the documented keys that are to be added to pagure/default_config.py if necessary - are you saying that this key should be omitted from the default config or should it be defined set to None or empty list?

There isn't really any need to put it in the default_config (which is equivalent to define it to None), we can if you want but it's not needed.

Fixed this in https://pagure.io/pagure/pull-request/3238

Commit 861b6dd7 fixes this pull-request

Pull-Request has been merged by pingou

Metadata