It's tough to do a comparison on this diff since the entire file is squashed onto one line!

I found the difference seemed to be near the front of the ~94 kB string, and it looks reasonable to me. I used Python and a 94 kB copy/paste to verify that the only change was that change near the beginning.

:ship: it.

Does this fix the preview as well?

No the preview is still broken. But I am not sure it can be fixed with just a CSS change. The change of behaviour of the emoji came in when we started using the emojione sprites.

I thought we always used the sprites, didn't we?

True, must have dreamed we didn't last night.

Then I guess the following is missing to fix the preview
https://pagure.io/pagure/blob/6271203760b50996a5125065b500a3c55c8349c3/f/pagure/static/emoji/emojione.sprites.css#_6

@pingou , @ryanlerch

So emojione have changed the ways their emoji sprites are working and default the emojis to 64x64. If we want smaller emoji it is a bit of pain (https://github.com/Ranks/emojione/issues/243, https://github.com/RocketChat/Rocket.Chat/issues/3735)

For me the easiest would be to switch back to a previous version of emojione, I don't think we need to have the latest.

What do you think ?

Isn't this fix working then?

/me hasn't tested it yet

This fix is just scaling down the visual of the emoji.

transform scale is just a visual scaling, the icons will still take up 64px of space in the content, so if you were to shrink the icons down to a diameter of 16px that would create 24px of empty space around the icon.

An the dropdown list will not have the emoji preview.

Ok, so yeah downgrading sounds right then indeed

@ryanlerch agreed?

Could we also add the non-minified versions of the JS and CSS files?

We could but I am not sure which version of emojione was previously used :s.

I have managed to find that the previous version used was 1.3.1. So I have added the non-minified JS, but could not find any non-minified CSS for the sprites.

I have renamed the files with the version used, so it will be easier to know witch version we are running.

I have managed to find that the previous version used was 1.3.1. So I have added the non-minified JS, but could not find any non-minified CSS for the sprites.

Awesome, thanks for looking into this.

For the CSS maybe we could run it through http://unminify.com/ and see if the output is somewhat usable?

I have renamed the files with the version used, so it will be easier to know witch version we are running.

Thanks!

Unminify css added and PR rebased :smile:

We looks some of the newer emojis, but we get the preview back and reasonable sizes :)

Let's merge, thanks @cverna !