#1550 fix total pages when no pull requests, forks, issues or repo
Merged by pingou. Opened by vibhcool.
vibhcool/pagure master  into  master

Download 1550.patch

There is a bug on pagure that in a project, if there are no issues , then it will show zero total pages i.e. 'page 1 of 0'.

There are similar bugs in forks list page and pull requests page.

1 new commit added

  • fix total pages when no pull requests, forks, issues or repo#2

2 new commits added

  • fix pep8 exceeding max characters problem
  • fix total pages when no pull requests, forks, issues or repo

1 new commit added

  • fix indentation error

By moving that line above the if(requests_cnt> 0) (you could drop the () btw), then you reduce the diff to two lines :)

length wise are we good? (I try to stick to the 80 chars limit)

1 new commit added

  • replace with 1 liner if condition

hm, looks like jenkins is not happy, are the tests passing for you locally?

yes, code is working on my local machine

I made the length wise changes and replaced if condition with one liner if condition

Thanks! :)

Pull-Request has been merged by pingou

Metadata