#1654 Fix the 'My Pull Request' functionality
Closed by pingou. Opened by rahulbajaj.
rahulbajaj/pagure DropDown_Funtionality  into  master

Download 1654.patch

Apparently, the dropdown on the dashboard does not provide
correct functionality for the 'My Pull Request' option.

This patch rectifies the functionality of 'My Pull Request'
option on the dropdown placed at the dashboard.

Apparently, the dropdown on the dashboard does not provide correct functionality for the 'My Pull Request' option.

So what are you observing and what were you expecting? On my local instance of pagure, it seems to behave as expected.

@pingou, Hey.

check this out - http://img.susepaste.org/22738614 , check the url too :)

When you click on that 'My Pull Request', you will get the o/p as - http://img.susepaste.org/24326993

It says i have no pull request :cry: but i guess i have pull requests!

So this pr take care of it :)

So nope, a) this PR doesn't take care of it, see the URL built in and b) technically this page is right since it lists PRs you can act on, and since you do not have commit to pagure itself, it doesn't list this PR as you cannot merge it yourself.

That being said, maybe the proper fix then is to include the PR you opened in that list :)

So nope, a) this PR doesn't take care of it, see the URL built in and b) technically this page is right since it lists PRs you can act on, and since you do not have commit to pagure itself, it doesn't list this PR as you cannot merge it yourself.

@pingou I am finding this kinda fishy because if you see http://img.susepaste.org/22738614
The 'My Pull Request' button is actually not suppose to be at the place where it is in the above screenshot.( check it in the /template/master.html -> it is actually suppose to be shown in the drop-down)

After implementing this pr you can see it is placed properly :) - http://img.susepaste.org/80468326.

That being said, maybe the proper fix then is to include the PR you opened in that list :)

Sorry, but i did not understand what you meant by this.

The 'My Pull Request' button is actually not suppose to be at the place where it is in the above screenshot.( check it in the /template/master.html -> it is actually suppose to be shown in the drop-down)

This was changed in : https://pagure.io/pagure/pull-request/1640 which isn't part of 2.10.1

After implementing this pr you can see it is placed properly :) - http://img.susepaste.org/80468326.

It already is on any instance that runs the latest code (which isn't the case of pagure.io since that one runs 2.10.1)

@pingou convinced, thanks for the explanation:)

I guess we should close this pr then :)

Agreed :)

Pull-Request has been closed by pingou

Metadata