I don't think this is right, as it will return (for pagure) 100 open issues of 700+, but there are 163 open issues and we are displaying the first 100, so 100 of 163 is correct.
There are a couple of tickets related to that progress bar which we could try fixing while at it: - https://pagure.io/pagure/issue/1481 - https://pagure.io/pagure/issue/1480
What do you think?
Yea sure why not. Btw - https://pagure.io/pagure/issue/1480 is not a big issue it's a very minor issue. Just let me know the description that you want to see on hover? I think for green part "Closed Issues Percentage" and for red part "Open Issues Percentage."
Maybe, X% of open issues on Y issues in total, what do you think?
X% of open issues on Y issues in total
Ok, But I didn't get the open issues logic that you described in the comment. I think you mean by that is only I have to make the changes for the percentage and rest I have to left as it is and In "100 out of 163" the 100 is basically showing how many issues are displaying on this page. Am I right?
Yes, that is correct :)
Do you want two different progress bars or common progress bar for open and closed issues pages. I mean that If this will be common then percentage will be always same and if different then the percentage will be different which seems not a good idea.
I wanted one progress bar, showing basically the same percentage (say 80% open - 20% closed) but one page will be the opposite of the other: - list of open tickets: 80% open - 20% closed - list of closed tickets: 20% closed - 80% open
That was a bit my original idea, but I am starting to wonder if we shouldn't just drop that progress bar, I seem to recall @ryanlerch not being fan of it as well.
I think progress bar is a good idea, which provides a quick idea that how much the development and developers are active for a specific project. Also I don't think we have to add two different progress bars, one will much better because in that we are getting both the open and closed percentage.
One thing the current progress bar was supposed to do as well is support filtering.
So say if you have 100 tickets of which 50 are open, in a regular view you would see 50%-50%, but if of these 50 48 were tagged: easyfix, if you saw the list of easyfix tickets, you would see 96% closed for 2% open.
Does that make sense?
Sounds good.
2 new commits added
If I read the change correctly, this is no longer needed no?
Total ^ issues count?
Nevermind, it is :)
Just for getting the vice-versa issues count no need to write a separate query for that. We have both total and one type of issues count so using this we can get the other type.
rebased
Could we split this line over multiple lines? It is really long and hard to follow as it is here.
Same as above, it would be nice to split this over multiple lines :)
Except for the last two small comments, this seems good to go :)
Looking great, thanks!
Pull-Request has been merged by pingou