pagure

#1718 Fix request_diff showing instead of commit_list in new tab
Merged by pingou. Opened by cep.
cep/pagure master  into  master

Download 1718.patch

Fixed the issue where opening the 'Commits' tab in a new browser
tab showed the 'Files Changed' tab instead.

Fixes https://pagure.io/pagure/issue/787

1 new commit added

  • Proper links for PR tabs

The subsequent commit fixes https://pagure.io/pagure/issue/1698.
Issues #787 and #1698 are closely related.
Edited by cep

Looking good, I'll have to test it locally but the code makes sense to me, thanks ! :)

neat and clean :thumbsup: :)

@pingou @rahulbajaj Thanks :)

It almost works :)

Basically it works for the classic use-case of clicking on the tabs, then sharing that link works but it doesn't work when highlighting some part of the PR and sharing that link, for example: https://pagure.io/pagure/pull-request/1718#_1,8-10

So we're close but there is one more use-case to consider :)

1 new commit added

  • Handle URL hashes for highlights.

@pingou I think that fixes it :)

I also wrapped the entire thing in #pr-wrapper, just to make sure we only hide .tab-panes local to the PR page.

rebased

Thanks!

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.