pagure

#1720 Raise an exception when a PR was made against a branch that no longer exists
Merged by pingou. Opened by pingou.
no_target_branch  into  master

Download 1720.patch

Basically, a fork can open a PR against a certain branch of another repo
but nothing prevents this other repo to delete that branch without
merging that pull-request, leading to a situation where pagure crashes
since the target branch of that pull-request no longer exists.

With this commit, the pull-request will hang, open, not accessible (since
we can't compute the diff) until the target branch is re-created by the
admin allowing the diff to be re-generated.
This is of course not an ideal situation but it prevents running into
un-explained 500 errors.

Relates to https://pagure.io/pagure/issue/1358

Perhaps indicate "in the target repo"?

1 new commit added

  • Document what to do in case of inaccessible pull-requests

You are viewing the target repo, so I thought this may be more confusing than anything since it could imply another repo, no?

Ah, right. Okay

Looks good to me. :snowflake:

Thanks! :)

"between the source and target of the pull-request"

Since this is a new branch, they would need to run "git push origin "

ok

sure

1 new commit added

  • Improve the wording the command in the documentation about inaccessible PRs

3 new commits added

  • Improve the wording and the command in the documentation about inaccessible PRs
  • Document what to do in case of inaccessible pull-requests
  • Raise an exception when a PR was made against a branch that no longer exists

Good once more. :rabbit:

Thanks! :)

Thanks! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.