Fixes : https://pagure.io/pagure/issue/1674 https://pagure.io/pagure/issue/1732
This PR is not up for review yet :smile:
rebased
Are you still working on this one?
@pingou yes, apparently everything is going correct, i guess. Getting a little messy with the preview button - http://img.susepaste.org/47279975
Nitpicking here, but could we use no spaces between parantheses and arguments? Eg. $("#preview") instead of $( "#preview" )?
$("#preview")
$( "#preview" )
If we aren't linting JS, I suppose this is just personal preference. So this is just a suggestion :)
We seem to be using the same id for new comment previews. We should use a different one here.
id
Semi-colon :)
sure, thanks :)
sure :)
This pr is open for review and testing now :smile:
here you may also use toggleclass() method link : http://stackoverflow.com/questions/7002039/easiest-way-to-toggle-2-classes-in-jquery
This looks fine to me but either we need to adjust #1803 to also take into account this preview panel or we need to adjust this to behave as in #1803.
And it needs to be rebased anyway :)
@pingou I guess we shall adjust this with respect to #1803 :)
Rebased and updated to use the toggleClass in https://pagure.io/pagure/pull-request/3085
Commit c2137d23 fixes this pull-request
Pull-Request has been merged by pingou
Fixes : https://pagure.io/pagure/issue/1674
https://pagure.io/pagure/issue/1732