#1751 Fix running the test suite
Merged by pingou. Opened by pingou.
fix_tests  into  master

Download 1751.patch
no initial comment

why also orig_repo.is_empty?

These should probably be <th id="issue-title-{{ loop.index }}"> in roadmap.html. We'll have more than one #issue-title if we have two or more milestones.

Corresponding changes here as well.

Fair, that is likely unneeded indeed :)

More likely this should be a class, or even just removed, there are no point adding IDs if we do not do anything with them, and the ID itself is wrong, it's not an issue title it's a milestone.

can we get this pr in ? :microphone:

Apart from @vivekanand1101 's comment all other seems fine to me :) so :thumbsup:

2 new commits added

  • Drop the id='issue-title' when the content is actually not an issue title
  • Only check if the fork is empty to say that it is

rebased

rebased

LGTM :thumbsup:

:thumbsup:

Pull-Request has been merged by pingou

Metadata