Hi there,

Thanks for this pull-request, however, I wonder if this issues wasn't this already
addressed in https://pagure.io/pagure/pull-request/1744 ?

The couple of spelling mistakes are still worth fixing though :)

Aren't you un-doing the PR #1744 with this change?

General comment: I believe pep8 does not like a space between the opening bracket and the first argument ie the ( log changed here. :)

@pingou now it seems there is no conflict, isn't it?

Yes there are no conflict but it seems to be undoing the change made in #1744, isn't it?

Yes, this undo the changes, actually it is another solution for the issue that #1744 solves.

But doesn't this solution seem more complex?

Basically, I am a little confused, since this PR seems to fix an issue that has already been fixed, so I am not sure what to do.

I pulled the request as i was also working on the issue (wasn't aware that it was solved day before, my fault) , So as my approach was different, So I pulled request.

In the solution, I used obj object (argument in log_action method) to save the logs' user_id attribute.

If the the solution is complex, then you shall not merge it.

@pingou I shall fix pep8 errors :P

@pingou IMHO I think we should keep the fix for spelling mistakes and if @vibhcool is fine with dropping other changes :smile:

@farhaan , @pingou working on this :D

@pingou @farhaan , i have modified the pr to the spelling mistakes, dropped the other changes :)

This is looking good. Could we just squash the three commits into one? I'm normally in favor of leaving things to show the evolution, but here 3 commits for a simple diff at the end seem more noise than info :)

@pingou yes , on it !!!

Perfect, thanks!