pagure

#1762 Do not automatically update the last_updated or updated_on fields
Merged by pingou. Opened by pingou.
no_auto_update  into  master

Download 1762.patch

Turns out that there are a few cases where to adjust the data in the
database and we do not need/want the user to know it changed.
One classic example: merge status are stored in the database. When a
pull-request is merged, the merge status of all the open pull-request
is cleared.
Before this commit, it meant that suddenly all the open pull-request had
their updated_on field updated to the current time, while in practice
nothing changed for this PR.

Since we are manually updating this field where we want, in this commit
we are removing the feature updating the data automatically.
And bonus point, it turns out this does not need an alembic migration
since this onupdate is not stored in the database itself, it is in fact
a feature of SQLAlchemy.

\cc @mreynolds

Ahh, I thought that might of been the issue. Ack

rebased

Thanks for the review. Let's hope it solves the issue, otherwise it will be tricky to track down :s

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.