#1765 Only connect to the smtp server if we're going to send an email
Merged by pingou. Opened by pingou.
fix_socket_smtp  into  master

Download 1765.patch

Otherwise, we keep on going and we will print the email in the logs
as we do.

1 new commit added

  • Move where the smtp object is instanciated

I think smtp will always be None here.

Not at the second iteration :)

You're right! LGTM :thumbsup:

:thumbsup:

Cool, thanks for the review and testing :)

rebased

Pull-Request has been merged by pingou

Metadata