#1774 Fix keeping the current filters when updating the status of the tag used
Merged by pingou. Opened by pingou.
fix_filtering  into  master

Download 1774.patch

Fixes https://pagure.io/pagure/issue/1772

Needs a rebase but else looks good to me :)

a one line change here: https://pagure.io/pagure/blob/master/f/pagure/ui/issues.py#_664
would have done :P

@vivekanand1101 not entirely since the argument was missing from some of the URL, but if it works entirely with this one-liner, feel free to submit a PR, it doe simplify the code :)

i see now . :/

I understand why this should work, i checked it is working but, i still don't understand why this bug is occurring :/

The basic reason is: https://pagure.io/pagure/blob/master/f/pagure/ui/issues.py#_614-615

When the status is allwe do not want to filter by status, so we change status to None, but then when it is passed onto the template, it messes with us :-s

The alternative would be to use a different variable within issues.py to pass to pagure.lib for the filtering.

rebased

:thumbsup:

Thanks for the reviews folks :)

Pull-Request has been merged by pingou

Metadata