It would be nice to introduce this section before we talk about alembic config files. i.e. Move this paragraph to before we start using alembic.

Rest looks good :) :thumbsup:

:thumbsup:

Good call

@cep want to have a final look?

alembic to know and apply

I'm not completely sure, but it looks like the database URL is replaced by the one in pagure's config, irrespective of whether it is present in alembic.ini. Whereas, the docs say it is only replaced when missing.

Is that right, or did I miss something?

Looks like this is just createdb.py (not pagure_createdb.py) now?

indeed :)

It is installed as pagure_createdb.py by the spec file, I do see the problem for user who installed outside of the RPM. I guess this might deserve a .. note::

You're reading this right because the doc is referring to the changes in env.py rather than the changes here.
Do you think we should we try to get the url and only replace it if it's missing?

Yes, if you cloned the source, then it's just createdb.py. +1 for adding a note :)

That would work! :)

@pingou Sorry, I don't know how I missed the notification about your comments. This should be good to go after the couple of minor changes mentioned :)

Jenkins is failing due to faitout :(

Need another rebase and :ship: it

@pingou we should rebase and merge this PR. I just tested it again to setup the docker-compose environment.

Once this is merged it it will be easy to fix #2719 :smile:

Let's go ahead and do it then :)