Unit-tests for this one?
Should we try to add unit-tests for these?
yes, yes. I was starting to do that and ran the tests , got about 50 fails and even more Errors. :/
All related to this change?
rebased
1 new commit added
I wonder if we could place the if/else just around this line :)
I thought the same earlier but, it does involve the word issue
Reading this section in the template, we would need to just adjust this line and the one under. At worst, just doing the
itself would already reduce some duplication
9 new commits added
All good to me, let's rebase and merge :)
Pull-Request has been merged by pingou