#1826 Some changes required for dist-git
Merged by pingou. Opened by vivekanand1101.
vivekanand1101/pagure dgit  into  master

Download 1826.patch
no initial comment

Unit-tests for this one?

Should we try to add unit-tests for these?

yes, yes. I was starting to do that and ran the tests , got about 50 fails and even more Errors. :/

All related to this change?

rebased

1 new commit added

  • turn on the ENABLE_TIKETS after the tests

I wonder if we could place the if/else just around this line :)

I thought the same earlier but, it does involve the word issue

Reading this section in the template, we would need to just adjust this line and the one under.
At worst, just doing the

itself would already reduce some duplication

1 new commit added

  • Don't repeat lines when it can be avoided in settings.html

9 new commits added

  • Don't repeat lines when it can be avoided in settings.html
  • turn on the ENABLE_TIKETS after the tests
  • Unit Test: ProjectBlackListed Exception
  • Unit Test: Test my_issues view function when tickets if turned off on the instance
  • Add new exception: ProjectBlackListedException
  • Allow viewing groups even when the user management is turned off
  • No need to show "my issues" page when tickets is disabled on instance
  • don't give option to make all issues as private by default if the issues are disabled on instance
  • Adjust repo settings frontend when ENABLE_TICKETS is False

All good to me, let's rebase and merge :)

rebased

Pull-Request has been merged by pingou

Metadata