PR#1841: Fix editing tags of a project -

pagure

#1841 Fix editing tags of a project

Merged Feb 3, 2017 by pingou. Opened Feb 2, 2017 by pingou.

fix_edit_tags into master

pingou commented Feb 2, 2017

We had an issue where we were trying to find Tag object using a query
that returned TagColored objects.
Of course that didn't work.
So when we were re-adding an existing tag to a new project, the logic was
trying to create a Tag object that already existed. That resulted in an
IntegrityError due to failing the unique constraint.

This commit fixes this by creating a new get_colored_tag that will
searched if a TagColored exists and adjust get_tag to search if a Tag
exists, making the workflow work.

Fixes https://pagure.io/pagure/issue/1818

bowlofeggs commented Feb 2, 2017

LGTM.

bowlofeggs commented Feb 2, 2017

It might be good to add a test to assert that this stays fixed.

pingou commented Feb 2, 2017

Yeah, I also want to do this, I'll add the tests before merging this.

Thanks for the review :)

farhaan commented Feb 3, 2017

:thumbsup:

1 new commit added