pagure

#1884 Add build_id to jenkins flag
Merged by pingou. Opened by farhaan.
farhaan/pagure jenkins-info  into  master

Download 1884.patch

This is a PR to add build_id to the jenkins flag attached to the pull-request
jenkins in general actually didn't give much insight to what the link is pointing to
adding a build id makes it more significant to the user to which build the URL
id pointing to.

Signed-off-by: Farhaan Bukhsh farhaan.bukhsh@gmail.com

3 new commits added

  • Add alembic migration for adding build_id column
  • Change Build ID to jenkins #build_id
  • Add Build ID to the CI flag

How is this going to work? You first make is nullable then don't allow it anymore.

Tbh it seems to me that a much easier solution would be to include the build id in the flag name :)

  • No need to change the DB
  • No need to enforce a build ID (while maybe other systems don't have that notion)

seems to be a clean solution should have though about it :)

rebased

rebased

not valid pep8 :)

I ran a pep8 pagure/lib/lib_ci.py but I got nothing . Can you point it to me ? :)

rebased

Thanks :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.