pagure

#1920 Add functionality for dealing with issues with no milestone
Merged by pingou. Opened by mreynolds.
mreynolds/pagure issue1912  into  master

Download 1920.patch

We need a way find issues that do not have a milestone set yet, and we need a way to find tickets that have specific milestones as well as no milestone. For example:

When new tickets are created they don't have a milestone, but we also have a NEEDS_TRIAGE milestone. So to find all the issues that need to triaged(aka have a milestone set) we need to find both types.

This patch adds a new "No milestone" button to the roadmap page, and it allows you to search issues by using multiple milestones(including "none"):

http://localhost.localdomain:5000/TEST_PROJ/issues?milestone=none&milestone=0.0

We can save this as a custom report for finding all the issues that need to be triaged.

pep8 won't like this one :)

We would need some unit-tests for this :)

pep8 does not complain about this line, but I'll remove it anyway

I thought it wouldn't like 2 empty lines in the middle of a block code

I don't have two empty lines though, just one :)

That would explain why pep8 doesn't complain :D

I'll blame the lack of sleep :)

rebased

Added unit tests

This is ready for review :)

I have a couple of commits for this branch, running the tests then pushing (then rebasing, one of the test that currently fails has been fixed in master).

I'd like to rework the template a bit, it seems to have some redundancy which we should be able to reduce using a macro.

rebased

1 new commit added

  • Use a macro to render the issue table in the roadmap

Ok, this is looking better for me.

@mreynolds does it still work as you want?

It doesn't work....

I tried:

http://localhost.localdomain:5000/PROJ/issues?milestone=none

This didn't return the issue with no milestone. I did not try the compound filter as the basic filter is failing

It is working! Sorry.

Ack!

Actually, I still see one issue with the pagination on /issues?milestone=none let me try to fix it

1 new commit added

  • Fix the pagination when filtering for the issues with no milestone assigned

Ok got it, final check?

Hmm so when I search on: ?milestone=none&milestone=1.1.11

I see:

2 Open Issues (of 1)

This looks wrong to me.

When I search on: ?milestone=1.1.11

1 Open Issues (of 2)

This seems correct

3 new commits added

  • Specify the milestones when looking for the issues and other issues
  • Drop the variable oth_issues in favor of oth_issues_cnt
  • Adjust the combine_url jinja filter to account for argument list

Ok pushed some more changes, mind reviewing them and testing them? :)

Looks good!!!

ACK

Cool, let's merge! :)

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.