PR#1931: Fix displaying issues when the custom field list has no options -

pagure

#1931 Fix displaying issues when the custom field list has no options

Merged Feb 20, 2017 by pingou. Opened Feb 17, 2017 by pingou.

fix_custom_fields into master

Download 1931.patch

pingou commented Feb 17, 2017

Basically this has happened a few times when importing a project into
pagure, the custom field of type list is created, given a value but no
data field (ie: no list of options).
This breaks the entire page since we fails at offering the different
options for that field.

With this fix, we do not fix the root cause but we do fix the symptoms.

pingou commented Feb 17, 2017

This has been hotfix in prod, it's ready for review but not for merging as I'd like to add unit-tests for this

pingou commented Feb 17, 2017

@mreynolds btw, I think you ran into this one a while back :)

cverna commented Feb 17, 2017

:thumbsup:

rebased

Feb 20, 2017

pingou commented Feb 20, 2017

Ok this is now ready for review (and should be merge as it actually fixes the code to even compile :))

cverna commented Feb 20, 2017