#1934 Modified Doc Strings
Merged by skarale. Opened by skarale.
skarale/pagure develop  into  master

Download 1934.patch

pagure/pagure/hooks/mail.py
pagure/pagure/hooks/pagure_ci.py

The change itself looks fine, but the commit message should be reworded a little I think.

The usual rule is:

  • A short description of the commit (max 72 chars)
  • An empty line
  • A longer description of the change (80 chars max per line) - optional

1 new commit added

  • Fixed Issue #1885: Added sign-off-by line when using web edit.

There are two different commits that are fixing two un-related issues. So I would prefer to have them into two different PRs (and the first commit still needs to have its message reworded)

There are two different commits that are fixing two un-related issues. So I would prefer to have >them into two different PRs (and the first commit still needs to have its message reworded)

I am working on the same. Once I done with removing merge conflicts, I will send two different PR.

1 new commit added

  • Modified Doc Strings from following files:

The commit message still needs to be reworded :(

rebased

@skarale why not amend the commit message and complete this PR :smile:

I'm going to merge this one manually :)

Commit f6d28c46 fixes this pull-request

Pull-Request has been merged by skarale@redhat.com

Metadata