pagure/pagure/hooks/mail.py pagure/pagure/hooks/pagure_ci.py
The change itself looks fine, but the commit message should be reworded a little I think.
The usual rule is:
1 new commit added
There are two different commits that are fixing two un-related issues. So I would prefer to have them into two different PRs (and the first commit still needs to have its message reworded)
There are two different commits that are fixing two un-related issues. So I would prefer to have >them into two different PRs (and the first commit still needs to have its message reworded)
I am working on the same. Once I done with removing merge conflicts, I will send two different PR.
The commit message still needs to be reworded :(
rebased
@skarale why not amend the commit message and complete this PR :smile:
I'm going to merge this one manually :)
Commit f6d28c46 fixes this pull-request
Pull-Request has been merged by skarale@redhat.com
pagure/pagure/hooks/mail.py
pagure/pagure/hooks/pagure_ci.py