#1948 Change in size of preview on adding a big image and auto formatted the css according to style guide.
Closed by pingou. Opened by smitthakkar96.
smitthakkar96/pagure imageOverflow  into  master

Download 1948.patch
no initial comment

I would prefer to keep this section as is, especially considering the formatting that you are proposing is messing up the comments.

@smitthakkar96 Hi, good job :)

Can you please split the image preview changes and formatting changes into two separate PRs?

@cep how do I do that?

@smitthakkar96 Here's one way you could do it:

  • Create a branch from master, only make changes relevant to the image preview, push it and create a PR.

  • Create another branch from master, only make changes related to formatting, push it and create another PR.

You can ofcourse use this PR for one of those things (and modify the title and details accordingly) but that's entirely up to you :)

Hi there, do you need help w/ anything?

I'm going to close this PR, please reopen it when your changes are ready to be reviewed :)

Thanks!

Pull-Request has been closed by pingou

Metadata