pagure

#1957 Fix the unit-tests and enforce failing on jenkins if the tests are failing
Merged by pingou. Opened by pingou.
fix_tests  into  master

Download 1957.patch
no initial comment

1 new commit added

  • Print out the last two commits

Why not put this on the first line
I'm going to assume you want to abort if any of the setup fails too.

1 new commit added

  • Set +e after running the tests

1 new commit added

  • Fail early if the setup fails

You can drop this check: if $? != 0, it would've crashed due to set -e :)

One small suggestion, but looks good to me.

Indeed, thanks

1 new commit added

  • No longer check the return code, set -e takes care of it

Thanks for the review! :)

:articulated_lorry:

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.