Did you test this? the change looks a little odd looking at it

Hey @skarale ,

As per the conversation I had with @pingou we landed up on the design that there should be a checkbox in the project setting page which has a Signed-Off By setting , if the check box is checked then the Signed-Off By line is attached to the commit message.

You need to put some JS in the edit_file.html which checks if the the project has Signed-Off By setting enabled and if yes then only you should add it to the commit message.

You can check how things are done in Project options in -->Settings there are options like Activate always merge etc , look into them and post any queries if you have either on IRC or here.

@pingou @farhaan Sure I will implement this change and send the PR.

@farhaan Wouldn't it be easier / cleaner to pre-fill the textarea with the Signed-off By message (in the template itself) instead of using JS to do it?

@cep agreed you have point there !

@skarale what is the progress on this ?

ping?

Ok I'm going to close this PR, feel free to re-open it when you have your changes ready to be reviewed :)