pagure

#2028 Fixing showing tags even when some of them are not formatted as expected
Merged by pingou. Opened by pingou.
odd_tagger  into  master

Download 2028.patch

We encountered in https://pagure.io/pagure/issue/1991 an issue where some
tags objects were not formatted as libgit2 expects them to be.
In this case, there were no email attached to the person doing the tag,
the tagger, and libgit2 would raise an ValueError exception on this.
With this commit, since we cannot access the object, we just catch this
exception and move on.
It's a pity since we will not be able to show these tags, but at least
we will be able to show the rest of them.

Fixes https://pagure.io/pagure/issue/1991

LGTM, but I suggest adding tests.

I'd love to add tests but I do not know how that situation was created in the first place so it's a little hard to reproduce :)

Or do you mean I just trigger the exception via mock w/o trying to reproduce the issue?

I'm going to merge as is but I wrote a ticket so that we do not forget to add the test later: https://pagure.io/pagure/issue/2043

rebased

Pull-Request has been merged by pingou
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.