#2061 Create the CLI pagure-admin and drop the /admin endpoint in the flask app
Merged by pingou. Opened by pingou.
pagure_admin  into  master

Download 2061.patch
no initial comment

typo, config file

You could use double quotes for the help string so that you don't have to escape the 's of user's.

Just a couple of comments, otherwise LGTM.

Indeed, will fix :)

Yeah, though I think I'll keep this way. I'll give it some thoughts

rebased

Finally, I went with both suggestions :) (and rebased)

Thanks for the review!

I think that the fact that someone can run this tool (aka, they can read the config file that has database credentials and access to write the keys) is good enough.

This should work way more stable than the web interface version :).
Looks sane to me.

So currently it's not doing anything w/ the config file, what should we do: default to /etc/pagure/pagure.cfg? Use the environment variable PAGURE_CONFIG? Use a CLI argument?

I would say: let's just depend on the default handling.
So, by default it reads PAGURE_CONFIG and then /etc/pagure/pagure.cfg. Let's keep it that way for the CLI as well for consistency sake?

Adding another argument might be interesting, but it could just set the env to use the normal code?

Let's do that then, default to /etc/pagure/pagure.cfg unless otherwise specified with a PAGURE_CONFIG env variable

rebased

Looks good to me.

Let's merge!

Thanks for the reviews :)

Pull-Request has been merged by pingou

Metadata