LGTM
OK
I think, we should keep condition checking as "if requests_cnt > 0".
I think, we should keep original condition here.
Any reasons why? :)
in previous check, we are checking if requests_cnt is positive number or not. if not then we are doing some calculation. "if requests_cnt" will be true for all negative and positive numbers which defeats the purpose of if condition.
But this value of requests_cnt is returned by a database query performing a COUNT query, so this cannot be negative afaik
requests_cnt
COUNT
ping?
OK.
Does that mean this PR is ready to be merged?
@pingou I am OK with changes. So we can merge this.
Thanks!
rebased
Pull-Request has been merged by pingou