PR#2120: Adjust the logic when filtering issues by priorities -

pagure

#2120 Adjust the logic when filtering issues by priorities

Merged Mar 17, 2017 by pingou. Opened Mar 16, 2017 by pingou.

fix_test_priority into master

pingou commented Mar 16, 2017

In the database priorities are stored in tickets as integer so we cannot
query them as string directly.
The approach taken with this commit allows to filter by priority given
its rank (integer) or its label (name).

Thanks to faitout for pointing it out

bowlofeggs commented Mar 16, 2017

I recommend making a new test to check this rather than adding it to an existing test. Adding it like this confuses the purpose of the test and also makes it very long and more difficult to understand. Keeping the tests short and to the point makes them easier to understand, and also makes problems easier to debug when they fail.

bowlofeggs commented Mar 16, 2017

LGTM.

rebased

Mar 17, 2017

pingou commented Mar 17, 2017

Tests have been split into two as suggested :)

Thanks for the review :)

Pull-Request has been merged by pingou

Mar 17, 2017

Metadata

Assignee

None

Tags

No Tags

pagure

#2120 Adjust the logic when filtering issues by priorities Merged Mar 17, 2017 by pingou. Opened Mar 16, 2017 by pingou. fix_test_priority into master

Metadata

#2120 Adjust the logic when filtering issues by priorities

Merged Mar 17, 2017 by pingou. Opened Mar 16, 2017 by pingou.

fix_test_priority into master