PR#2130: Add a performance monitoring framework and initial test -

pagure

#2130 Add a performance monitoring framework and initial test

Merged Mar 21, 2017 by pingou. Opened Mar 20, 2017 by puiterwijk.

puiterwijk/pagure perf into master

puiterwijk commented Mar 20, 2017

This is a framework that allows testing for the number of times we walk over a git repository while processing a specific request.
This allows us to start testing for the number of git repository actions, since those constitute the majority of Pagure performance costs.

For verbose information while debugging, one can run the runserver as:

PAGURE_PERFREPO=true PAGURE_PERFREPO_VERBOSE=true ./runserver.py

This will print the collected performance statistics at the end of every request.

rebased

Mar 20, 2017

pingou commented Mar 20, 2017

Should we put like a warning of something, maybe just a comment about what number we should aim for?

rebased

Mar 20, 2017

rebased

Mar 20, 2017

rebased

Mar 20, 2017

rebased

Mar 20, 2017

3 new commits added

Add performance totals plugin
Add performance checks to the test suite
Add performance repo analyzer

Mar 20, 2017

pingou commented Mar 21, 2017

Idea: could we adjust runserver so that it has a parameter to turn on PAGURE_PERFREPO=true PAGURE_PERFREPO_VERBOSE=true directly? (as we do with -c/--config)

pingou commented Mar 21, 2017

'counters': {'diffs': 0, 'walks': 8}, should this include the inits as well?

pingou commented Mar 21, 2017

PERFORMANCE TOTALS:, should we be more explicit about what performances we're talking about? (pygit2 performance, git performance?)

pingou commented Mar 21, 2017

Otherwise, it's looking really quite neat :)

rebased

Mar 21, 2017

pingou commented Mar 21, 2017

Thanks! :)

Pull-Request has been merged by pingou

Mar 21, 2017