From abe2995da042fe4a41aee93574d126ec548a38d1 Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Jun 09 2015 10:44:53 +0000
Subject: [PATCH 1/2] Hide the form to create pull-requests if the user is not an admin of the repo


---

diff --git a/pagure/templates/pull_request.html b/pagure/templates/pull_request.html
index ea85aca..67aaabc 100644
--- a/pagure/templates/pull_request.html
+++ b/pagure/templates/pull_request.html
@@ -60,7 +60,7 @@
 </div>
 {% endif %}
 
-{% if form %}
+{% if form and repo_admin %}
 <section class="new_project">
   <form action="{{ url_for('.new_request_pull', username=username,
     repo=repo.name, commitid=commitid, branch_from=branch_from,
diff --git a/pagure/ui/fork.py b/pagure/ui/fork.py
index 442915d..1c217f2 100644
--- a/pagure/ui/fork.py
+++ b/pagure/ui/fork.py
@@ -691,8 +691,10 @@ def new_request_pull(repo, branch_to, branch_from, username=None):
         return flask.redirect(flask.url_for(
             'view_repo', username=username, repo=repo.name))
 
+    repo_admin=is_repo_admin(repo)
+
     form = pagure.forms.RequestPullForm()
-    if form.validate_on_submit() and is_repo_admin(repo):
+    if form.validate_on_submit() and repo_admin:
         try:
             if repo.settings.get(
                     'Enforce_signed-off_commits_in_pull-request', False):
@@ -764,4 +766,5 @@ def new_request_pull(repo, branch_to, branch_from, username=None):
         branches=sorted(orig_repo.listall_branches()),
         branch_to=branch_to,
         branch_from=branch_from,
+        repo_admin=repo_admin,
     )

From e1494ea2293336e45ce1bca37faf6e4d178e272e Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Jun 09 2015 10:44:53 +0000
Subject: [PATCH 2/2] Replace the Pull-Request button by a Compare button if the user it not a repo admin


---

diff --git a/pagure/templates/repo_info.html b/pagure/templates/repo_info.html
index 681dd14..e89afd3 100644
--- a/pagure/templates/repo_info.html
+++ b/pagure/templates/repo_info.html
@@ -128,15 +128,11 @@
     {% endif %}
     {% if diff_commits and authenticated %}
     <span id="request_pull">
-        {% if branchname %}
         <a href="{{ url_for('new_request_pull',
             username=username, repo=repo.name,
-            branch_to='master', branch_from=branchname) }}">Request pull</a>
-        {% else %}
-            <a href="{{ url_for('new_request_pull',
-                username=username, repo=repo.name,
-                branch_to='master', branch_from='master') }}">Request pull</a>
-        {% endif %}
+            branch_to='master', branch_from=branchname or 'master') }}">
+          {% if repo_admin %}Request pull{% else %}Compare{% endif %}
+        </a>
     </span>
     {% endif %}
     <ul>
diff --git a/pagure/ui/repo.py b/pagure/ui/repo.py
index 623a50a..198e9c0 100644
--- a/pagure/ui/repo.py
+++ b/pagure/ui/repo.py
@@ -131,6 +131,7 @@ def view_repo(repo, username=None):
         last_commits=last_commits,
         tree=tree,
         diff_commits=diff_commits,
+        repo_admin=is_repo_admin(repo),
     )
 
 
@@ -204,6 +205,7 @@ def view_repo_branch(repo, branchname, username=None):
         last_commits=last_commits,
         tree=sorted(last_commits[0].tree, key=lambda x: x.filemode),
         diff_commits=diff_commits,
+        repo_admin=is_repo_admin(repo),
     )
 
 
@@ -303,6 +305,7 @@ def view_commits(repo, branchname=None, username=None):
         diff_commits=diff_commits,
         page=page,
         total_page=total_page,
+        repo_admin=is_repo_admin(repo),
     )