PR#2199: Fix our markdown processor for strikethrough -

pagure

#2199 Fix our markdown processor for strikethrough

Merged Apr 4, 2017 by pingou. Opened Mar 30, 2017 by pingou.

fix_strikethrough into master

pingou commented Mar 30, 2017

Fixes https://pagure.io/pagure/issue/2198

cverna commented Mar 30, 2017

:thumbsup:

lsedlar commented Mar 30, 2017

I think it should use a non-greedy match. Test case ~~foo~~ and ~~bar~~ should have two <del> tags IMO. Currently it produces <del>foo~~ and ~~bar</del>.

pingou commented Mar 30, 2017

Fair

1 new commit added

Make the strikethrough regex non-greedy and add a test for this

Mar 30, 2017

pingou commented Mar 31, 2017

@lsedlar what do you think of this PR now?

lsedlar commented Apr 4, 2017

@pingou Sorry about the long delay, the current patch looks good to me.

pingou commented Apr 4, 2017

Thanks for the review :)

rebased

Apr 4, 2017

Pull-Request has been merged by pingou

Apr 4, 2017

Metadata

Assignee

None

Tags

No Tags

pagure

#2199 Fix our markdown processor for strikethrough Merged Apr 4, 2017 by pingou. Opened Mar 30, 2017 by pingou. fix_strikethrough into master

Metadata

#2199 Fix our markdown processor for strikethrough

Merged Apr 4, 2017 by pingou. Opened Mar 30, 2017 by pingou.

fix_strikethrough into master